On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote: > > I botched the makefile changes for the new .c files. > > > > I believe it should be like this: > > > > obj-$(CONFIG_TCG_TPM) += tpm-core.o > > tpm-core-y := tpm.o tpm-dev.o tpm-sysfs.o > > > > > I added a suitable patch with the appropriate EXPORT_SYMBOL_GPL > > > declarations to my testing branch. (also see next message) > > > > EXPORT_SYMBOL_GPL is not correct, these are in-module references, not > > cross module references, and I've deliberately not exported them to > > prevent drivers from trying to use them inappropriately.
> Of course you're right - I just wanted to get it compile as fast as > possible ;) It looks like my solution changes the tpm module name to tpm-core.o. This should be noted in the commit log: In doing so we also change the core tpm module name from 'tpm' to 'tpm-core', this is because kbuild does not like it if a multi-file module has a .c file of the same name. Is that OK? It follows the pattern other systems have in the kernel. If this is not OK, then I think we have to rename tpm.c to tpm-XX.c to make the build system work. I've consolidated all the remarks and changes thus far on my github: https://github.com/jgunthorpe/linux/commits/tpm-devel ec94ce9d29298ba75cec83a136fd841f8da9d528 (plus 1 more untested patch to remove the tpm-bios module) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/