Hi Magnus, Thank you for your commnets. > > +obj-$(CONFIG_ARCH_SHMOBILE) += shmobile/ > > +obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += shmobile/ > > Here I believe it is enough that you only use > CONFIG_ARCH_SHMOBILE_MULTI. ...
That is because it supports three configuration, 1. MULTI + KZM9D_REFERENCE + COMMON_CLK 2. KZM9D_REFERENCE + COMMON_CLK 3. KZM9D but, > ... Building common clocks to coexist with the > old legacy board code does not make any sense IMO. ... I think so, too. And from the view of testing, having smaller variants is better. # easier :) > > +ifeq ($(CONFIG_COMMON_CLK), y) > > +obj-$(CONFIG_ARCH_EMEV2) += clk-emev2.o > > +endif > > I don't think you would need the above ifeq/endif wrapper if you only > used CONFIG_ARCH_SHMOBILE_MULTI above. Right. Anyway, because you have make kzm9d-reference things simpler, now we don't need to worry about it. Thanks, /yoshii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
