On Tue, 8 Oct 2013 12:10:37 +0200, Ingo Molnar wrote: > -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > -Wvolatile-register-var,-Wvolatile-register-var),y) > +ifeq ($(feature-volatile-register-var), 1) > CFLAGS += -Wvolatile-register-var > endif > > diff --git a/tools/perf/config/feature-checks/Makefile > b/tools/perf/config/feature-checks/Makefile > index 46b7650..5693299 100644 > --- a/tools/perf/config/feature-checks/Makefile > +++ b/tools/perf/config/feature-checks/Makefile > @@ -3,6 +3,7 @@ FILES= \ > test-hello \ > test-stackprotector-all \ > test-stackprotector \ > + test-volatile-register-var \ > test-libnuma > > CC := $(CC) -MD > @@ -22,6 +23,9 @@ test-stackprotector-all: > test-stackprotector: > $(BUILD) -Werror -fstack-protector > > +test-volatile-register-var: > + $(BUILD) -Werror -Wvolatile-register-var
I'm not sure this test is necessary at all. The gcc manpage says this warning is enabled by -Wall, and we add -Wall to CFLAGS before doing feature checks. So all gcc versions that support -Wvolatile-register-var enables it by default without this check and older gcc versions will always fail the feature check. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
