On Tue, 2013-10-15 at 14:29 +0000, Kelleter, Günther wrote: > Addresses are BCD encoded, not ASCII. x25_addr_ntoa got it right. [] > Wrong length calculation leads to rejection of CALL ACCEPT packets. [] > diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c [] > @@ -98,7 +98,7 @@ int x25_parse_address_block(struct sk_buff *skb, > } > len = *skb->data; > - needed = 1 + (len >> 4) + (len & 0x0f); > + needed = 1 + ((len >> 4) + (len & 0x0f) + 1) / 2;
This calculation looks odd. Perhaps use bcd.h instead? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
