On 25 October 2013 15:40, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > And in my opinion acpi_cpufreq_init() should just return an error code if it > can't register the driver, like in the (untested) patch below. > > Rafael > > > --- > drivers/cpufreq/acpi-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-pm/drivers/cpufreq/acpi-cpufreq.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/acpi-cpufreq.c > +++ linux-pm/drivers/cpufreq/acpi-cpufreq.c > @@ -988,10 +988,10 @@ static int __init acpi_cpufreq_init(void > > /* don't keep reloading if cpufreq_driver exists */ > if (cpufreq_get_current_driver()) > - return 0; > + return -EEXIST; > > if (acpi_disabled) > - return 0; > + return -ENODEV; > > pr_debug("acpi_cpufreq_init\n");
Much better.. And probably the first return has caused the bug Linus faced.. Acked-by: Viresh Kumar <viresh.ku...@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/