On Tue, 22 Oct 2013 14:56:48 +0400, Stanislav Fomichev wrote: > Don't use special flag to indicate power-only mode, use proc_num == 0. > -P now equals to -n 0
I don't see how it does same thing. You mean it by skipping draw_process_bars() and draw_wakeups() on patch 1? It'd be better changelog explains the details. > > Signed-off-by: Stanislav Fomichev <[email protected]> > --- > tools/perf/builtin-timechart.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c > index d965f26308ed..e6c041301aa4 100644 > --- a/tools/perf/builtin-timechart.c > +++ b/tools/perf/builtin-timechart.c > @@ -50,8 +50,6 @@ static u64 turbo_frequency; > > static u64 first_time, last_time; > > -static bool power_only; > - > > struct per_pid; > struct per_pidcomm; > @@ -912,7 +910,7 @@ static int determine_display_tasks(u64 threshold) > /* no exit marker, task kept running to the end */ > if (p->end_time == 0) > p->end_time = last_time; > - if (p->total_time >= threshold && !power_only) > + if (p->total_time >= threshold) > p->display = 1; > > c = p->all; > @@ -923,7 +921,7 @@ static int determine_display_tasks(u64 threshold) > if (c->start_time == 1) > c->start_time = first_time; > > - if (c->total_time >= threshold && !power_only) { > + if (c->total_time >= threshold) { > c->display = 1; > count++; > } > @@ -1086,6 +1084,15 @@ parse_process(const struct option *opt __maybe_unused, > const char *arg, > return 0; > } > > +static int > +parse_power(const struct option *opt __maybe_unused, > + const char *arg __maybe_unused, > + int unset __maybe_unused) > +{ > + proc_num = 0; > + return 0; > +} > + > int cmd_timechart(int argc, const char **argv, > const char *prefix __maybe_unused) > { > @@ -1094,7 +1101,8 @@ int cmd_timechart(int argc, const char **argv, > OPT_STRING('i', "input", &input_name, "file", "input file name"), > OPT_STRING('o', "output", &output_name, "file", "output file name"), > OPT_INTEGER('w', "width", &svg_page_width, "page width"), > - OPT_BOOLEAN('P', "power-only", &power_only, "output power data only"), > + OPT_CALLBACK_NOOPT('P', "power-only", NULL, NULL, > + "output power data only", parse_power), And I'd like to keep it as BOOLEAN option - it's simpler and more straight-forward IMHO. How about adding if (power_only) proc_num = 0; after parsing the command line options? Thanks, Namhyung > OPT_CALLBACK('p', "process", NULL, "process", > "process selector. Pass a pid or process name.", > parse_process), -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
