On Tue, Oct 29, 2013 at 7:34 AM, Wei Yongjun <[email protected]> wrote: > From: Wei Yongjun <[email protected]> > > In case of error, the function clk_get_sys() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun <[email protected]> > --- > arch/arm/mach-spear/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c > index d449673..3263a34 100644 > --- a/arch/arm/mach-spear/time.c > +++ b/arch/arm/mach-spear/time.c > @@ -222,7 +222,7 @@ void __init spear_setup_of_timer(void) > } > > gpt_clk = clk_get_sys("gpt0", NULL); > - if (!gpt_clk) { > + if (IS_ERR(gpt_clk)) { > pr_err("%s:couldn't get clk for gpt\n", __func__); > goto err_iomap; > }
Acked-by: Viresh Kumar <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
