On 11/01, David Long wrote: > > On 10/29/13 15:59, Oleg Nesterov wrote: >> >> Or. arm can actually reimplement set_swbp(). This doesn't mean the >> duplication of write_opcode() code, we can simply export this helper. >> > > That actually looks to me like the cleanest approach. I have changed > the static write_opcode() to a global uprobe_write_opcode(), and now > call it from an arm set_swbp().
OK, great. > Please do *not* make set_swbp() (and set_orig_insn()) static's. It > looks like we now have a use for at least one of them. I am not sure... it still seems to me it makes sense to cleanup this interface... But. I am not going to do this until we merge your changes. We will see then. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
