On Wed, Oct 30, 2013 at 06:33:25PM +0530, Vinod Koul wrote: > On Tue, Oct 29, 2013 at 09:47:55AM -0700, Olof Johansson wrote: > > This patch broke some TI platforms (using edma) due to namespace > > conflicts. The error is: > > > > ../../include/linux/dmaengine.h:54:2: error: expected identifier > > before numeric constant (for DMA_COMPLETE) > > > > .. it's because they define DMA_COMPLETE in include/platform_data/edma.h. > > > > The edma driver seems to overall lack prefixes and thus pollutes > > global namespaces, so it should be fixed up. > Yup this needs some work. > > I fixed up the error with below, can you pls verify. Pls note this is compile > tested only! > > -----><8--------------------------- > > From: Vinod Koul <vinod.k...@intel.com> > Date: Wed, 30 Oct 2013 18:22:30 +0530 > Subject: [PATCH] dmanengine: fix edma driver to not define DMA_COMPLETE > > edma header defines DMA_COMPLETE, this causes issues as commit adfedd9a32e4 > move > DMA_SUCCESS to DMA_COMPLETE. edma should properly namespace its defines and > needs a future fix > > Reported-by: Olof Johansson <o...@lixom.net> > Signed-off-by: Vinod Koul <vinod.k...@intel.com>
Thanks, I've applied this to fixes together with the follow-up from Sebastian. Cc:ing Mark since it touches drivers/soc. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
