> Yes, and it is always equal to regs->ip when pre_ssout() is called, > > > and do the necessary fixups after single stepping out of line. > > Exactly. So it is write-only (and meaningless) to the generic uprobe > code. We can (and perhaps should) move it into autask->saved_vaddr, > arch_uprobe_pre_xol() can initialize it. > > > The casual reading of this commit message, one can get an impression > > that vaddr is never needed. > > See above. The changelog doesn't say we can simply remove it, it says > "move it".
Okay, moving to arch_uprobe_task is fine. I probably got confused by "First of all it is not really needed," > > > Your change still retains it. > > > OK. How about dup_xol_work/dup_xol_vaddr ? > Yes fine with me. -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
