On Tue, Nov 12, 2013 at 01:14:30PM -0600, Larry Finger wrote: > On 11/12/2013 12:43 PM, Alexandre Demers wrote: > > r8712u pollutes dmesg and logs. Silence it and add a verbose option to > > KConfig if we ever > > really want to hear about it. > > > > v2: keep netdev_info instead of replacing it by a KERN_NOTICE > > > > --- > > drivers/staging/rtl8712/Kconfig | 7 +++++++ > > drivers/staging/rtl8712/rtl871x_mlme.c | 7 ++++--- > > 2 files changed, 11 insertions(+), 3 deletions(-) > > Do you really want the "v2" to be part of the patch title in the git repos? I > expect not, thus you should put it inside the []. All that stuff is stripped > off > when the patch is merged. > > Similarly, do you want the v2 line in the patch description to be part of the > permanent record? If not, move it below the --- line. > > You are also missing a Signed-off-by: line. Have you read > Documentation/SubmittingPatches? At least you should run every patch through > scripts/checkpatch.pl before submitting it. > > Finally, why do you want to add another Kconfig variable? I suggest either > deleting the logging statement, or commenting it out. I'm not sure that this > info would ever need logging.
To be a bit more clear here, we are activly _removing_ driver and subsystem specific DEBUG configuration flags, and moving everything to using the dynamic debug infrastructure in the kernel, as no user ever rebuilds their kernels/drivers, and we want to be able to get debugging information from them at times. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
