On Fri, Nov 15, 2013 at 08:27:58PM +0800, ZHAO Gang wrote: > 1. change function name: et1310_phy_power_down -> et1310_phy_power_switch > change function name to better describe its functionality. > > 2. as TODO file suggested, do this sort of things to reduce split lines > struct fbr_lookup *fbr; > fbr = rx_local->fbr[id]; > Then replace all the instances of "rx_local->fbr[id]" with fbr. > > 3. delete unnecessary variable in function et131x_init > variable u32 numrfd is not necessary in this function. > > 4. some code style change > > Signed-off-by: ZHAO Gang <gamer...@gmail.com> > --- > drivers/staging/et131x/et131x.c | 209 > ++++++++++++++++++++-------------------- > 1 file changed, 103 insertions(+), 106 deletions(-)
Hi Zhao, I'm a bit confused - these patches apply to the current head of staging-next, but not on top of your previous two patches. I assume that you're aiming to have these changes on top of your last two, so can you please re-spin them to apply cleanly to the head of (staging-next + your previous patches)? Cheers, Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
