* [email protected] <[email protected]> wrote:
> From: Stephen Boyd <[email protected]>
> Subject: sched_clock: document 4Mhz vs 1Mhz decision
>
> Bo Shen sent a patch to change this to 1Mhz instead of 4Mhz but according
> to Russell King the use of 4Mhz was intentional. Add a comment to this
> effect so that others don't try to change the code as well.
>
> Signed-off-by: Stephen Boyd <[email protected]>
> Cc: Bo Shen <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Signed-off-by: Andrew Morton <[email protected]>
> ---
>
> kernel/time/sched_clock.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff -puN
> kernel/time/sched_clock.c~sched_clock-document-4mhz-vs-1mhz-decision
> kernel/time/sched_clock.c
> --- a/kernel/time/sched_clock.c~sched_clock-document-4mhz-vs-1mhz-decision
> +++ a/kernel/time/sched_clock.c
> @@ -132,6 +132,10 @@ void __init sched_clock_register(u64 (*r
> clocks_calc_mult_shift(&cd.mult, &cd.shift, rate, NSEC_PER_SEC, 3600);
>
> r = rate;
> + /*
> + * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as
> + * 1832Khz
> + */
> if (r >= 4000000) {
> r /= 1000000;
> r_unit = 'M';
Instead of magic precision cutoff limits the better solution would be
to simply display not just decimal part but also the first 3 digits of
the fractional part:
1.123 Hz
990.134 kHz
1.832 MHz
12.314 GHz
etc. - then every number could be displayed in its natural unit
without magic precision limits.
It would also be mostly self-documenting.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
