Hello, Alexander.

On Fri, Oct 18, 2013 at 07:12:06PM +0200, Alexander Gordeev wrote:
> @@ -744,23 +744,6 @@ static int msix_capability_init(struct pci_dev *dev,
>  
>       return 0;
>  
> -out_avail:
> -     if (ret < 0) {
> -             /*
> -              * If we had some success, report the number of irqs
> -              * we succeeded in setting up.
> -              */
> -             struct msi_desc *entry;
> -             int avail = 0;
> -
> -             list_for_each_entry(entry, &dev->msi_list, list) {
> -                     if (entry->irq != 0)
> -                             avail++;
> -             }
> -             if (avail != 0)
> -                     ret = avail;
> -     }

Hmmm... so, before this, the function would have returned the partial
number of irqs that arch set up successfully.  Is it okay to lose that
information?  If so, can you please elaborate a bit more on why it's
okay in the description?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to