On 11/22/2013 01:56 PM, Heikki Krogerus wrote: > On Fri, Nov 22, 2013 at 11:40:32AM -0700, Stephen Warren wrote: >> On 11/22/2013 05:14 AM, Mika Westerberg wrote: >>> From: Heikki Krogerus <heikki.kroge...@linux.intel.com> >>> >>> All platforms using this driver are now converted to the new >>> descriptor-based GPIO interface. >> >> Don't you want to remove the fields from the pdata structure too, since >> it's pointless to set them anymore IIUC? > > Agreed. We should have removed them in this patch. > > I have prepared a separate patch where I remove those and some other > unused fields from the pdata structure (attachment). Would it be OK to > add that to this patch set? Or should this patch simply be updated?
I would suggest killing off the two GPIO fields in this patch, since it's logically part of this change. I think the balance of the patch is unrelated to gpiod conversion, so should probably be sent separately, although watch out for dependencies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
