On Tue, Nov 26, 2013 at 01:00:55PM +0100, Ingo Molnar wrote:
>
> * Jiri Olsa <jo...@redhat.com> wrote:
>
> > On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:
SNIP
> > >
> > > Also note that we have duplicate code for this in Makefile.perf
> > > already. Would it be possible to pass through this there and keep the
> > > main Makefile is just a thin, minimal wrapper that adds default
> > > parallelism, etc?
> >
> > well, thats what I actually tried to do.. pass the
> > processing to the Makefile.perf otherwise it stops
> > in Makefile
> >
> > I guess you want some generic way of doing that
>
> If it's just these two phony targets that need to be in the main
> makefile then I guess your approach is the simplest one and we should
> do it like that instead of complicating the interface. If it gets
> messier in the future we can reconsider?
>
sounds good, pelase check v2
thanks,
jirka
---
Once the tags/TAGS file is generated it's never rebuilt
until it's removed by hand.
The reason is that the Makefile does not treat tags/TAGS
as targets but as files and thus won't rebuilt them
once they are in place.
Adding PHONY tags/TAGS targets into Makefile.
Signed-off-by: Jiri Olsa <jo...@redhat.com>
Cc: Ingo Molnar <mi...@kernel.org>
Cc: Frederic Weisbecker <fweis...@gmail.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Mike Galbraith <efa...@gmx.de>
Cc: Stephane Eranian <eran...@google.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
---
tools/perf/Makefile | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..eefb9fb 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -60,8 +60,11 @@ endef
#
# Needed if no target specified:
+# (Except for tags and TAGS targets. The reason is that the
+# Makefile does not treat tags/TAGS as targets but as files
+# and thus won't rebuilt them once they are in place.)
#
-all:
+all tags TAGS:
$(print_msg)
$(make)
@@ -77,3 +80,5 @@ clean:
%:
$(print_msg)
$(make)
+
+.PHONY: tags TAGS
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
