On Tue, Nov 26, 2013 at 8:17 PM, Olof Johansson <o...@lixom.net> wrote: > On Tue, Nov 26, 2013 at 11:14 AM, Joe Perches <j...@perches.com> wrote: >> On Tue, 2013-11-26 at 10:56 -0800, Olof Johansson wrote:
>>> amba_set_drvdata(adev, chip); >>> - dev_err(&adev->dev, "PL061 GPIO chip @%08x registered\n", >>> - adev->res.start); >>> + dev_err(&adev->dev, "PL061 GPIO chip @%pa registered\n", >>> + &adev->res.start); >> >> This looks as if this should not use dev_err, but maybe dev_info >> and maybe it should use %pR, &adev->res > > Yep, I have as a somewhat long-standing todo to scrub for needlessly > elevated printk levels (err and warn) on various drivers during boot, > thanks for shortcutting that. :) Bah copy/paste bug from my side ... > I'll let Linus decide on pR vs pa. I go with the thing you tested, fixed up the commit and also switched to dev_info(). But now I have worse PL061 problems than this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
