Hi Krzysztof, On 10 December 2013 14:39, Krzysztof Kozlowski <k.kozlow...@samsung.com> wrote:
> static int s5m8767_reg_disable(struct regulator_dev *rdev) > { > struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev); > int ret, reg; > - int mask = 0xc0, enable_ctrl; > + int mask = S5M8767_ENCTRL_MASK, enable_ctrl; Couldn't we get rid of this mask variable here too? Otherwise the patch looks good to me. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/