On Fri, Dec 13, 2013 at 05:22:40PM +0100, Oleg Nesterov wrote: > Andrea. Thanks a lot for the detailed reply. > > On 12/13, Andrea Arcangeli wrote: > > > > On Wed, Dec 11, 2013 at 08:18:55PM +0100, Oleg Nesterov wrote: > > > > get_huge_page_tail checks different invariants in the VM_BUG_ON and is > > only used by gup.c not sure why to call that here. > > Compared to __get_page_tail_foll(get_page_head => F) get_huge_page_tail() > lacks the ->first_page->_count, but it is called right after > get_page_unless_zero(page_head) so to me get_huge_page_tail() looks a bit > better. > > Personally, I think that even this change > > --- x/kernel/events/../../mm/internal.h > +++ x/kernel/events/../../mm/internal.h > @@ -47,11 +47,9 @@ static inline void __get_page_tail_foll( > * page_cache_get_speculative()) on tail pages. > */ > VM_BUG_ON(atomic_read(&page->first_page->_count) <= 0); > - VM_BUG_ON(atomic_read(&page->_count) != 0); > - VM_BUG_ON(page_mapcount(page) < 0); > if (get_page_head) > atomic_inc(&page->first_page->_count); > - atomic_inc(&page->_mapcount); > + get_huge_page_tail(page); > } > > /* > > makes sense. But this is minor and subjective, I am not going to argue.
The above diff looks a straightforward cleanup you could submit it as a separate patch in a v2 series. This more clearly shows the difference between the two functions, so there is less overlap too. Feel free to change it further if you want, but the current model was to have get_huge_page_tail only for arch/*/mm/gup.c (in mm.h) and __get_page_tail_foll in internal.h for mm/*.c and with the ability to obtain the head page too (needed in some of the mm/*.c cases, and never needed for arch/*/mm/gup.c). > I'll try to make v2 based on -mm and your suggestions. Ok great! Thanks, Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
