On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: > + idev->debug_root = debugfs_create_dir("ion", NULL); > + if (IS_ERR_OR_NULL(idev->debug_root)) > + pr_err("ion: failed to create debug files.\n");
There's no need to check for this at all, you just printed out an error message if CONFIG_DEBUGFS is not enabled, which isn't all that nice. Something to clean up later, no big deal now. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/