On Sat, Dec 14, 2013 at 01:10:38PM -0800, Colin Cross wrote: > On Sat, Dec 14, 2013 at 8:52 AM, Greg KH <[email protected]> wrote: > > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: > >> + idev->debug_root = debugfs_create_dir("ion", NULL); > >> + if (IS_ERR_OR_NULL(idev->debug_root)) > >> + pr_err("ion: failed to create debug files.\n"); > > > > There's no need to check for this at all, you just printed out an error > > message if CONFIG_DEBUGFS is not enabled, which isn't all that nice. > > > > Something to clean up later, no big deal now. > > Patch 75/115 (ion: remove IS_ERR_OR_NULL) replaces this chunk with: > idev->debug_root = debugfs_create_dir("ion", NULL); > if (!idev->debug_root) > pr_err("ion: failed to create debug files.\n"); > which won't print an error if debugfs is disabled.
If debugfs is disabled, debugfs_create_dir() returns ERR_PTR(-ENODEV). So are you sure you tested this? :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
