On 12/14/2013 09:06 AM, Greg KH wrote: > On Fri, Dec 13, 2013 at 05:18:00PM -0800, John Stultz wrote: >> 0117-ion-Reenable-the-build.patch - This can be applied to the end of >> the series, or folded into the last patch "ion: Update system heap >> shrinker to use the new count/scan interface" > Was there a 0116 patch somewhere? No.. the disable build patch was inserted between patch 1 and 2, so after the renumbering the re-enable patch was 117.
When I selected the disable patch to send I renamed it 0001 just to make it more clear which one it would apply to. Sorry for the confusion. > Everything works fine until this one (i.e. the driver doesn't build), > but after applying this patch, the build breaks with a ton of undefined > symbols at link time, here's a sample of some of them: > > ERROR: "ion_carveout_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_chunk_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_system_heap_create" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_carveout_heap_create" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_system_contig_heap_create" > [drivers/staging/android/ion/ion_heap.ko] undefined! > ERROR: "ion_cma_heap_create" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_chunk_heap_create" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_buffer_destroy" [drivers/staging/android/ion/ion_heap.ko] > undefined! > ERROR: "ion_heap_map_user" [drivers/staging/android/ion/ion_chunk_heap.ko] > undefined! > ERROR: "ion_heap_unmap_kernel" > [drivers/staging/android/ion/ion_chunk_heap.ko] undefined! > ERROR: "ion_heap_map_kernel" [drivers/staging/android/ion/ion_chunk_heap.ko] > undefined! > ERROR: "ion_heap_pages_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] > undefined! > ERROR: "ion_pages_sync_for_device" > [drivers/staging/android/ion/ion_chunk_heap.ko] undefined! > ERROR: "ion_buffer_cached" [drivers/staging/android/ion/ion_chunk_heap.ko] > undefined! > ERROR: "ion_heap_buffer_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] > undefined! > > So I'm not going to apply this patch, but I have the 115 previous > patches (I took your modified 001 patch that you sent off-list to me.) ? Hrmm. I'm not seeing this (I wouldn't have sent the patches if I did!). If you have the chance, could you send me your config? > Care to fix up the symbol issues in a new series of patches and then > enabling the driver to build? Will do. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
