On 12/14/2013 01:48 PM, Greg KH wrote: > On Sat, Dec 14, 2013 at 12:06:45PM -0800, John Stultz wrote: >> ION doesn't export the proper symbols for it to be a module. This >> causes build issues when ION is configured as a module. >> >> Since Andorid kernels rarely use modules (I think recent policy >> requires no modules?), go ahead and set the ION config to a bool >> from the tristate option. >> >> If folks decide ION as a module is important, we will have to go >> through and export the various needed symbols. >> >> Signed-off-by: John Stultz <[email protected]> >> --- >> drivers/staging/android/ion/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/android/ion/Kconfig >> b/drivers/staging/android/ion/Kconfig >> index a342d96..b95281e 100644 >> --- a/drivers/staging/android/ion/Kconfig >> +++ b/drivers/staging/android/ion/Kconfig >> @@ -1,5 +1,5 @@ >> menuconfig ION >> - tristate "Ion Memory Manager" >> + bool "Ion Memory Manager" > Or you can do: > depends on m > and leave it as a "tristate", then when switching it off, I think you > can then be prompted as 'm' again, but I could be wrong about that. > > So should ION ever be able to be built as a module in the future? My understanding is that Android is moving away from using modules, but others could comment more authoritatively. So I don't think this is an issue. But as I said in the patch, if folks do want to have ION as a module, we'll have to export all the various symbols that ION users need.
thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
