On Thu 2013-12-12 21:18:23, David Cohen wrote: > This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() more > smart. > > Despite those macros check for '#ifdef CONFIG_PM_SLEEP/RUNTIME' to avoid > setting the callbacks when such #ifdef's aren't defined, they don't > handle compiler to avoid messages like that: > > drivers/usb/host/xhci-plat.c:200:12: warning: ???xhci_plat_suspend??? defined > but not used [-Wunused-function] > drivers/usb/host/xhci-plat.c:208:12: warning: ???xhci_plat_resume??? defined > but not used [-Wunused-function] > > As result, those macros get rid of #ifdef's when setting callbacks but > not when implementing them. > > With this patch, drivers using SET_*_PM_OPS() macros don't need to #ifdef > the callbacks implementation as well.
Well... Interesting trickery, but it means that resulting kernel will be bigge due to the dead functions no? That may be acceptable tradeoff, but I guess its worth discussing... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
