於 四，2013-12-19 於 14:09 +0000，Matt Fleming 提到： > On Thu, 19 Dec, at 03:51:47PM, Lee, Chun-Yi wrote: > > UEFI time services, GetTime(), SetTime(), GetWakeupTime(), SetWakeupTime() > > are also > > supported by other non-IA64 architecutre with UEFI BIOS, e.g. x86. > > > > This patch changed RTC_DRV_EFI configuration to depend on EFI but not just > > IA64. It > > checks efi_enabled flag and efi-rtc driver should enabled. > > > > Cc: Matt Fleming <matt.flem...@intel.com> > > Cc: H. Peter Anvin <h...@zytor.com> > > Cc: Matthew Garrett <matthew.garr...@nebula.com> > > Cc: Thomas Gleixner <t...@linutronix.de> > > Cc: Ingo Molnar <mi...@redhat.com> > > Cc: Jan Beulich <jbeul...@suse.com> > > Signed-off-by: Lee, Chun-Yi <j...@suse.com> > > --- > > arch/x86/platform/efi/efi.c | 17 +++++++++++++++++ > > drivers/rtc/Kconfig | 2 +- > > 2 files changed, 18 insertions(+), 1 deletions(-) > > This patch needs to be justified. Enabling the EFI runtime *Time > functions just because they're available isn't good enough. We need to > know why this patch improves things, what use case does it solve? >
The main purpose of enable efi-rtc driver is providing interface to userspace access timezone field in EFI time services. Currently have two BIOS interfaces provided the timezone field accessing ability, ACPI TAD and EFI. I hope can enable them on x86_64 machines. > The general attitude has been that we want to invoke the runtime > services less, not more, due to the huge variety of runtime > implementation bugs. > I agreed, but userspace application should not be too often to access RTC. Maybe only when system boot and set timezone. Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
