Hello.

On 25-12-2013 7:28, Ding Tianhong wrote:

Use possibly more efficient ether_addr_equal
instead of memcmp.

Cc: Rupesh Gujare <rupesh.guj...@atmel.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: de...@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com>
Signed-off-by: Ding Tianhong <dingtianh...@huawei.com>
---
  drivers/staging/ozwpan/ozcdev.c  | 2 +-
  drivers/staging/ozwpan/ozproto.c | 5 +++--
  2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 6ce0af9..c363f66 100644
--- a/drivers/staging/ozwpan/ozcdev.c
+++ b/drivers/staging/ozwpan/ozcdev.c
@@ -448,7 +448,7 @@ int oz_cdev_start(struct oz_pd *pd, int resume)
        }
        spin_lock(&g_cdev.lock);
        if ((g_cdev.active_pd == NULL) &&
-               (memcmp(pd->mac_addr, g_cdev.active_addr, ETH_ALEN) == 0)) {
+               (ether_addr_equal(pd->mac_addr, g_cdev.active_addr))) {

   There's no point in enclosing function call into parens.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to