On Fri, Jan 03, 2014 at 05:23:37PM -0800, Mukesh Rathor wrote: > On Thu, 2 Jan 2014 13:41:34 -0500 > Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > > > On Thu, Jan 02, 2014 at 04:14:32PM +0000, David Vrabel wrote: > > > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > > > From: Mukesh Rathor <mukesh.rat...@oracle.com> > > > > > > > > In xen_add_extra_mem() we can skip updating P2M as it's managed > > > > by Xen. PVH maps the entire IO space, but only RAM pages need > > > > to be repopulated. > > > > > > So this looks minimal but I can't work out what PVH actually needs > > > to do here. This code really doesn't need to be made any more > > > confusing. > > > > I gather you prefer Mukesh's original version? > > I think Konrad thats easier to follow as one can quickly spot > the PVH difference... but your call.
I prefer the one that re-uses the existing logic. That has been - both in the hypervisor and in the Linux kernel for PVH - the path - just do nice little one-offs that do something simpler and easier than the old PV path. That way one can easily spot how PV vs PVH works for certain operations. It also from a testing coverage perspective means we end up using the same codepath for both PV and PVH - so we do get more testing exposure for different modes. > > thanks > mukesh > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
