> This patch splits individual sysreg functions into
> separate MFD cells, which then become individual
> platform devices with their own drivers.
>
> Signed-off-by: Pawel Moll <[email protected]>
> ---
> .../devicetree/bindings/arm/vexpress-sysreg.txt | 37 ++-
> arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 76 ++++++-
> arch/arm/boot/dts/vexpress-v2m.dtsi | 76 ++++++-
> arch/arm/mach-vexpress/v2m.c | 23 +-
> drivers/mfd/Kconfig | 11 +
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/vexpress-sysreg.c | 247
> +++++++++++++++------
> include/linux/vexpress.h | 16 +-
> 8 files changed, 377 insertions(+), 111 deletions(-)
<snip>
> +static struct mfd_cell vexpress_sysreg_cells[] = {
> + {
> + .name = "syscon",
> + .of_compatible = "arm,vexpress-sysreg,sys_id",
> + .num_resources = 1,
> + .resources = (struct resource []) {
> + DEFINE_RES_MEM(SYS_ID, 0x4),
> + },
> + .platform_data = &vexpress_sysreg_sys_id_pdata,
> + .pdata_size = sizeof(vexpress_sysreg_sys_id_pdata),
Not sure how comfortable I am with using Device Tree and populating
platform_data with information which by the looks of it you're
planning to make persistent. What's stopping you from using a DT
property to name the block, or better yet, just use the compatible
string? Also, won't naming these blocks in DT also aid other OSes?
<snip>
> +static int vexpress_sysreg_probe(struct platform_device *pdev)
> {
> - vexpress_sysreg_base = base;
> - vexpress_sysreg_setup(NULL);
> + struct resource *mem;
> + void __iomem *base;
> + struct bgpio_chip *mmc_gpio_chip;
> +
> + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!mem)
> + return -EINVAL;
> +
> + base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
> + if (!base)
> + return -ENOMEM;
> +
> + vexpress_config_set_master(vexpress_sysreg_get_master(base));
> +
> + /*
> + * Duplicated SYS_MCI pseudo-GPIO controller for compatibility with
> + * older trees using sysreg node for MMC control lines.
> + */
> + mmc_gpio_chip = devm_kzalloc(&pdev->dev, sizeof(*mmc_gpio_chip),
> + GFP_KERNEL);
> + if (!mmc_gpio_chip)
> + return -ENOMEM;
> + bgpio_init(mmc_gpio_chip, &pdev->dev, 0x4, base + SYS_MCI, NULL,
> + NULL, NULL, NULL, 0);
> + mmc_gpio_chip->gc.ngpio = 2;
> + gpiochip_add(&mmc_gpio_chip->gc);
> +
> + return mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
> + vexpress_sysreg_cells,
> + ARRAY_SIZE(vexpress_sysreg_cells), mem, 0, 0);
Don't use 0 as NULL, you will cause a sparse error.
<snip>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
