Em Thu, Jan 16, 2014 at 10:49:31AM +0900, Namhyung Kim escreveu:
> Gaurav reported that perf cannot profile JIT program if it executes
> the code on heap. This was because current map__new() only handle JIT
> on anon mappings - extends it to handle no_dso (heap, stack) case too.
>
> This patch assumes JIT profiling only provides dynamic function
> symbols so check the mapping type to distinguish the case. It'd
> provide no symbols for data mapping - if we need to support symbols on
> data mappings later it should be changed.
But we do support symbols in data mappings, that is why we have
MAP__VARIABLE, etc, can you elaborate?
Gaurav, do this fixes the problem you reported? Can I have your
Tested-by: tag?
- Arnaldo
> Reported-by: Gaurav Jain <gj...@fb.com>
> Signed-off-by: Namhyung Kim <namhy...@kernel.org>
> ---
> tools/perf/util/map.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index 9b9bd719aa19..ee1dd687a262 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -69,7 +69,7 @@ struct map *map__new(struct list_head *dsos__list, u64
> start, u64 len,
> map->ino = ino;
> map->ino_generation = ino_gen;
>
> - if (anon) {
> + if ((anon || no_dso) && type == MAP__FUNCTION) {
> snprintf(newfilename, sizeof(newfilename),
> "/tmp/perf-%d.map", pid);
> filename = newfilename;
> }
> @@ -93,7 +93,7 @@ struct map *map__new(struct list_head *dsos__list, u64
> start, u64 len,
> * functions still return NULL, and we avoid the
> * unnecessary map__load warning.
> */
> - if (no_dso)
> + if (type != MAP__FUNCTION)
> dso__set_loaded(dso, map->type);
> }
> }
> --
> 1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
