On 01/14/2014 06:48 PM, David Rientjes wrote: >> > +/* >> > + * Custom allocators (like the slabs) use 'struct page' fields >> > + * for all kinds of things. This resets the page's state so that >> > + * the buddy allocator will be happy with it. >> > + */ >> > +static inline void allocator_reset_page(struct page *page) > This is ambiguous as to what "allocator" you're referring to unless we > look at the comment. I think it would be better to name it > slab_reset_page() or something similar.
I stuck it in mm.h and deliberately didn't call it 'slab_something' so that zsmalloc (in staging) could use this as well. The "allocator" part of the name was to indicate that any allocator could use it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/