We currently get __init_or_module from init.h (implicitly) but if we move that to module.h we will get failures like this:
In file included from /home/paul/git/linux-head/arch/arm/include/asm/gpio.h:10:0, from include/linux/gpio.h:48, from include/linux/of_gpio.h:20, from drivers/input/touchscreen/ads7846.c:30: arch/arm/mach-at91/include/mach/gpio.h:191:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_GPIO_periph' arch/arm/mach-at91/include/mach/gpio.h:192:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_A_periph' arch/arm/mach-at91/include/mach/gpio.h:193:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_B_periph' arch/arm/mach-at91/include/mach/gpio.h:194:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_C_periph' arch/arm/mach-at91/include/mach/gpio.h:195:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_D_periph' arch/arm/mach-at91/include/mach/gpio.h:196:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_gpio_input' arch/arm/mach-at91/include/mach/gpio.h:197:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_gpio_output' arch/arm/mach-at91/include/mach/gpio.h:198:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_deglitch' arch/arm/mach-at91/include/mach/gpio.h:199:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_debounce' arch/arm/mach-at91/include/mach/gpio.h:200:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_multi_drive' arch/arm/mach-at91/include/mach/gpio.h:201:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_pulldown' arch/arm/mach-at91/include/mach/gpio.h:202:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_disable_schmitt_trig' make[3]: *** [drivers/input/touchscreen/ads7846.o] Error 1 Fix it up in advance by including module.h explicitly. Cc: Andrew Victor <li...@maxim.org.za> Cc: Nicolas Ferre <nicolas.fe...@atmel.com> Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com> Cc: Russell King <li...@arm.linux.org.uk> Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> --- arch/arm/mach-at91/include/mach/gpio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h index 5fc2377..78abd64 100644 --- a/arch/arm/mach-at91/include/mach/gpio.h +++ b/arch/arm/mach-at91/include/mach/gpio.h @@ -14,6 +14,7 @@ #define __ASM_ARCH_AT91RM9200_GPIO_H #include <linux/kernel.h> +#include <linux/module.h> /* for __init_or_module */ #include <asm/irq.h> #define MAX_GPIO_BANKS 5 -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/