On 01/22, Oleg Nesterov wrote:
>
> On 01/22, Alex Thorlton wrote:
> > > + case PR_SET_THP_DISABLE:
> > > + case PR_GET_THP_DISABLE:
> > > + down_write(&me->mm->mmap_sem);
> > > + if (option == PR_SET_THP_DISABLE) {
> > > + if (arg2)
> > > + me->mm->def_flags |= VM_NOHUGEPAGE;
> > > + else
> > > + me->mm->def_flags &= ~VM_NOHUGEPAGE;
> > > + } else {
> > > + error = !!(me->mm->flags && VM_NOHUGEPAGE);
> >
> > Should be:
> >
> > error = !!(me->mm->def_flags && VM_NOHUGEPAGE);
>
> No, we need to return 1 if this bit is set ;)
Damn, you are right of course, we need "&". I didn't notice "&&"
in the patch I sent and misunderstood your "&&" above ;) Sorry.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
