On Wed, Feb 05, 2014 at 06:08:02AM -0800, Mike Turquette wrote: > Quoting Sebastian Hesselbarth (2014-01-25 10:19:06) > > This patch set fixes clk init order that went upside-down with > > v3.14. I haven't really investigated what caused this, but I assume > > it is related with DT node reordering by addresses. > > > > Anyway, with v3.14 for MVEBU SoCs, the clock gating driver gets > > registered before core clocks driver. Unfortunately, we cannot > > return -EPROBE_DEFER in drivers initialized by clk_of_init. As the > > init order for our drivers is always core clocks before clock gating, > > we maintain init order ourselves by hooking CLK_OF_DECLARE to one > > init function that will register core clocks before clock gating > > driver. > > > > This patch is based on pre-v3.14-rc1 mainline and should go in as > > fixes for it. As we now send MVEBU clk pull-requests to Mike directly, > > I suggest Jason picks it up as a topic branch. > > Sebastian, > > These patches look OK to me. I'd rather take Gregory Clement's "respect > the clock dependencies in of_clk_init" patch towards 3.15, so this fix > will still be necessary for the current -rc's. > > Jason, will you be sending a PR?
Ahh, just saw this now. ignore my previous comments about using Gregory's series as the fix. Sure, I'll put this together for a pr to the clk tree. thx, Jason. > > The patches have been boot tested on Dove and compile-tested only > > for Kirkwood, Armada 370 and XP. > > > > Sebastian Hesselbarth (4): > > clk: mvebu: armada-370: maintain clock init order > > clk: mvebu: armada-xp: maintain clock init order > > clk: mvebu: dove: maintain clock init order > > clk: mvebu: kirkwood: maintain clock init order > > > > drivers/clk/mvebu/armada-370.c | 21 ++++++++++----------- > > drivers/clk/mvebu/armada-xp.c | 20 +++++++++----------- > > drivers/clk/mvebu/dove.c | 19 +++++++++---------- > > drivers/clk/mvebu/kirkwood.c | 34 ++++++++++++++++------------------ > > 4 files changed, 44 insertions(+), 50 deletions(-) > > > > --- > > Cc: Mike Turquette <mturque...@linaro.org> > > Cc: Jason Cooper <ja...@lakedaemon.net> > > Cc: Andrew Lunn <and...@lunn.ch> > > Cc: Gregory Clement <gregory.clem...@free-electrons.com> > > Cc: Thomas Petazzoni <thomas.petazz...@free-electrons.com> > > Cc: Ezequiel Garcia <ezequiel.gar...@free-electrons.com> > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > -- > > 1.8.5.2 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/