On Tue, Feb 11, 2014 at 7:08 PM, Josh Cartwright <jo...@codeaurora.org> wrote: > It sure would be convenient if platform_device had a 'const struct > of_device_id *of_id_entry' member similar to the existing struct > platform_device_id one, that was set up during platform device matching. > Most platform_driver users of of_match_node() would simply go away.
Can't the entry be shared for both platform_device_id and of_device_id? Only one of them can be valid at the same time, right? Ideally, all xxx_device_id look like struct xxx_device_id { ... /* bus-specific ID information */ kernel_ulong_t driver_data; }; This may be formalized in some way, using a base class, but thay may require reordering the fields, like: struct base_device_id { kernel_ulong_t driver_data; long id[0]; }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/