On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <[email protected]> wrote: > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: >> >> There is no reason to care about irq_desc in that context, escpecially >> as irq_data for that interrupt is retrieved as well. >> >> Use the proper accessor for the msi descriptor >> >> Signed-off-by: Thomas Gleixner <[email protected]> >> Cc: Bjorn Helgaas <[email protected]> >> Cc: Jingoo Han <[email protected]> >> Cc: Mohit Kumar <[email protected]> >> Cc: pci <[email protected]> > > Acked-by: Jingoo Han <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]> Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. Bjorn > A few days ago, I noticed that irq_data_get_msi() can be used. > However, I did not submit the same patch. I really appreciate > your patch. :-) > > Best regards, > Jingoo Han > >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> Index: tip/drivers/pci/host/pcie-designware.c >> =================================================================== >> --- tip.orig/drivers/pci/host/pcie-designware.c >> +++ tip/drivers/pci/host/pcie-designware.c >> @@ -294,14 +294,12 @@ no_valid_irq: >> static void clear_irq(unsigned int irq) >> { >> unsigned int pos, nvec; >> - struct irq_desc *desc; >> struct msi_desc *msi; >> struct pcie_port *pp; >> struct irq_data *data = irq_get_irq_data(irq); >> >> /* get the port structure */ >> - desc = irq_to_desc(irq); >> - msi = irq_desc_get_msi_desc(desc); >> + msi = irq_data_get_msi(data); >> pp = sys_to_pcie(msi->dev->bus->sysdata); >> if (!pp) { >> BUG(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
