H. Peter, I forgot to Cc you on this one. As you are the one I'm looking for an Ack from.
-- Steve On Thu, 27 Feb 2014 10:46:18 -0500 Steven Rostedt <[email protected]> wrote: > [Request for Ack] > > From: Petr Mladek <[email protected]> > > If a failure occurs while modifying ftrace function, it bails out and will > remove the tracepoints to be back to what the code originally was. > > There is missing the final sync run across the CPUs after the fix up is done > and before the ftrace int3 handler flag is reset. > > Link: > http://lkml.kernel.org/r/[email protected] > > Fixes: 8a4d0a687a5 "ftrace: Use breakpoint method to update ftrace caller" > Cc: [email protected] # 3.5+ > Signed-off-by: Petr Mladek <[email protected]> > Signed-off-by: Steven Rostedt <[email protected]> > --- > arch/x86/kernel/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 6b566c8..69885e2 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -660,8 +660,8 @@ ftrace_modify_code(unsigned long ip, unsigned const char > *old_code, > ret = -EPERM; > goto out; > } > - run_sync(); > out: > + run_sync(); > return ret; > > fail_update: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
