On Wed, Mar 05, 2014 at 10:21:09AM +1100, Stephen Rothwell wrote:
> Hi John,
>
> On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell <s...@canb.auug.org.au>
> wrote:
> >
> > If I revert commit 161d78555435 "Revert "Staging: rtl8812ae: remove
> > modules field of rate_control_ops"", it fails differently:
> >
> > In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
> > drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
> > drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
> > function 'ieee80211_dsss_chan_to_freq'
> > [-Werror=implicit-function-declaration]
> > ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
> > 'rtl8821ae_rx_query_desc':
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument
> > 1 of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type
> > [enabled by default]
> > if ((ieee80211_is_robust_mgmt_frame(hdr)) &&
> > ^
> > In file included from include/net/mac80211.h:20:0,
> > from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
> > from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
> > include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
> > argument is of type 'struct ieee80211_hdr *'
> > static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
> > 'rtl8821ae_dm_clear_txpower_tracking_state':
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u
> > invokes undefined behavior [-Waggressive-loop-optimizations]
> > rtldm->bb_swing_idx_ofdm[p] = rtldm->default_ofdm_index;
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
> > for (p = RF90_PATH_A; p < MAX_RF_PATH; ++p) {
> > ^
> >
> > So please revert 161d78555435, and then fix this other error.
>
> That fix could be a simple as just disabling the affected staging tree
> driver and letting Greg know. Or you could actually fix it.
John and Larry and I have been talking about how to handle some
cross-tree issues, and I should be merging with his tree soon to handle
them, hopefully this will get resolved at that point in time as well.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
