> >> Add support for S2MPA01 voltage and current regulator.
>
> >> +
> >> +struct s2mpa01_info {
> >> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
> >
> > Hi,
> >
> > It seems that s2mpa01_info->rdev is not used anywhere, except as return
> > value of devm_regulator_register. I think you can remove it completely.
>
> Yes. I will send a follow up patch for this.
Let's not break things and fix them up later. Fix it in this patch.
> > Beside that, can this driver be merged into existing s2mps11 regulator
> > driver?
>
> Haven't analyzed this yet. Will look into the possibility of consolidation
> later.
As above. If consolidation is possible it should be take care of in
the first instance.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
