On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote:
Hi Peter,

On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley <pe...@hurleysoftware.com> wrote:

          [...]

          /*
           * Indicate that there isn't a port here anymore.
           */
          uport->type = PORT_UNKNOWN;

          state->uart_port = NULL;

How did this ever work?

Detaching the ll driver from the tty port in this manner is not ok;
as you already note, it blows up if consoles are still running.

No one unbinds serial drivers using serial_core, as all these drivers are
for fixed hardware?

Yep, never tested until now :)
Do you need this to work?

Hot-pluggable usb-serial doesn't use serial_core.

I guess none of the 8250 PCI adapters are hot-pluggable...

Regards,
Peter Hurley



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to