On Sun, 2014-03-16 at 18:21 +0100, David Herrmann wrote:
[...]
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -74,6 +74,11 @@ void netdev_set_default_ethtool_ops(struct net_device *dev,
>  #define NET_RX_SUCCESS               0       /* keep 'em coming, baby */
>  #define NET_RX_DROP          1       /* packet dropped */
>  
> +/* interface name assignment types */
> +#define NET_NAME_ENUM                0       /* enumerated by kernel 
> (default) */
> +#define NET_NAME_USER                1       /* provided by user-space */
> +#define NET_NAME_RENAMED     2       /* renamed by user-space */
[...]

I think these definitions should be put in a UAPI header.  Even if the
names don't end up being used by userland, that would make it clear that
the numbers are a stable ABI.

Ben.

-- 
Ben Hutchings
Computers are not intelligent.  They only think they are.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to