On 19 March 2014 08:44, Ezequiel Garcia <ezequiel.gar...@free-electrons.com> wrote: > Tested-by: Ezequiel Garcia <ezequiel.gar...@free-electrons.com> Thanks! > On the other side, this board has no pm_power_off() support, which means > kernel_halt() is called after kernel_power_off(). > > I'm not sure if a NULL pm_power_off() is supported, but this makes my kernel > crash in a reboot notifier that's called twice (first in kernel_power_off > and then in kernel_halt):
The omap board I'm using has a null pm_power_off. I added code to bypass kernel_power_off in the event pm_power_off is null like this: diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index a5f702a..d96b910 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -594,7 +594,8 @@ static void power_down(void) case HIBERNATION_PLATFORM: hibernation_platform_enter(); case HIBERNATION_SHUTDOWN: - kernel_power_off(); + if (pm_power_off) + kernel_power_off(); break; #ifdef CONFIG_SUSPEND case HIBERNATION_SUSPEND: This follows the behavior in the reboot syscall which does it this way also. I'm testing this now, and it seems work fine. If this looks good, I can add it as an additional patch. Thanks, Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/