On 19 March 2014 13:47, Sebastian Capella <sebastian.cape...@linaro.org> wrote: > diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c > index a5f702a..d96b910 100644 > --- a/kernel/power/hibernate.c > +++ b/kernel/power/hibernate.c > @@ -594,7 +594,8 @@ static void power_down(void) > case HIBERNATION_PLATFORM: > hibernation_platform_enter(); > case HIBERNATION_SHUTDOWN: > - kernel_power_off(); > + if (pm_power_off) > + kernel_power_off(); > break; > #ifdef CONFIG_SUSPEND > case HIBERNATION_SUSPEND: > > > This follows the behavior in the reboot syscall which does it this way > also. I'm testing this now, and it seems work fine. If this looks > good, I can add it as an additional patch.
BTW, one thing I would point out is that kernel_power_off and kernel_halt call the same notifier but with different parameters (SYS_POWER_OFF and SYS_HALT). If pm_power_down is null, I dont see why we'd want to notify SYS_POWER_OFF before SYS_HALT. With the previous change I'm assuming there's no benefit, so please chime in if you know a reason. Thanks, Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
