Hi, 2014-03-20 22:35 GMT+01:00 Alexander Holler <hol...@ahsoftware.de>: > The initramfs generation is broken for file and directory names which contain > colons or spaces. Print an error and don't try to continue. > > Tests: > > cd linux > make defconfig > echo 'CONFIG_BLK_DEV_INITRD=y' >> .config > echo 'CONFIG_INITRAMFS_ROOT_UID=0' >>.config > echo 'CONFIG_INITRAMFS_ROOT_GID=0' >>.config > echo 'CONFIG_INITRAMFS_COMPRESSION_NONE=y' >>.config > echo 'CONFIG_INITRAMFS_SOURCE="/tmp/bugroot"' >>.config > > Problem with colons: > > mkdir -p /tmp/bugroot/a:b > make -j4 bzImage # no error > make bzImage # try again, oops > > Problem with spaces: > > mkdir -p /tmp/bugroot/a\ b > make -j4 bzImage # no error > zcat usr/initramfs_data.cpio.gz | cpio --extract --list # oops, no content > > Signed-off-by: Alexander Holler <hol...@ahsoftware.de> > --- > scripts/gen_initramfs_list.sh | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh > index 17fa901..aacf366 100644 > --- a/scripts/gen_initramfs_list.sh > +++ b/scripts/gen_initramfs_list.sh > @@ -171,6 +171,17 @@ dir_filelist() { > ${dep_list}header "$1" > > srcdir=$(echo "$1" | sed -e 's://*:/:g') > + > + # Files and directories with spaces and colons are unsupported. > + local unsupported=$(find "${srcdir}" -regex '.*\(:\| \).*') > + if [ ! -z "${unsupported}" ]; then > + printf "ERROR: Unable to handle files/directories with " >&2 > + printf "unsupported characters.\nPlease use other ways " >&2
'Please use other ways to...' (i.e. missing "to") > + printf "generate a cpio-archive.\nUnsupported files and " >&2 > + printf "directories are:\n$unsupported\n" >&2 > + exit 1 > + fi > + I think it would be worthy to tell the user what kind of characters are unsupported. For instance, tell them that 'spaces' are unsupported. > dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n") > > # If $dirlist is only one line, then the directory is empty > [...] -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/