On Fri, Mar 28, 2014 at 12:21:02PM +0530, Kishon Vijay Abraham I wrote: > commit ca488 (extcon: of: Remove unnecessary function call by using the > name of device_node) started using node name instead of device name > to get the extcon device. This breaks dwc3-omap since it's not able to > get the extcon device anymore. Fixed it by setting edev name of > palmas to be the same as its node name. > > Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com> > Reported-by: Felipe Balbi <ba...@ti.com>
Thanks Kishon, I tested something similar yesterday and I saw that it helped a lot. I'm still missing something (maybe DTS) because dwc3 still didn't probe even after fixing this. Reviewed-by: Felipe Balbi <ba...@ti.com> > --- > drivers/extcon/extcon-palmas.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index 2aea4bc..51dee21 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -23,6 +23,7 @@ > #include <linux/module.h> > #include <linux/interrupt.h> > #include <linux/platform_device.h> > +#include <linux/slab.h> > #include <linux/err.h> > #include <linux/mfd/palmas.h> > #include <linux/of.h> > @@ -188,11 +189,13 @@ static int palmas_usb_probe(struct platform_device > *pdev) > > palmas_usb->edev.supported_cable = palmas_extcon_cable; > palmas_usb->edev.dev.parent = palmas_usb->dev; > + palmas_usb->edev.name = kstrdup(node->name, GFP_KERNEL); > palmas_usb->edev.mutually_exclusive = mutually_exclusive; > > status = extcon_dev_register(&palmas_usb->edev); > if (status) { > dev_err(&pdev->dev, "failed to register extcon device\n"); > + kfree(palmas_usb->edev.name); > return status; > } > > @@ -230,6 +233,7 @@ static int palmas_usb_probe(struct platform_device *pdev) > > fail_extcon: > extcon_dev_unregister(&palmas_usb->edev); > + kfree(palmas_usb->edev.name); > > return status; > } > @@ -239,6 +243,7 @@ static int palmas_usb_remove(struct platform_device *pdev) > struct palmas_usb *palmas_usb = platform_get_drvdata(pdev); > > extcon_dev_unregister(&palmas_usb->edev); > + kfree(palmas_usb->edev.name); > > return 0; > } > -- > 1.7.9.5 > -- balbi
signature.asc
Description: Digital signature