On Mon, 31 Mar 2014, Linus Torvalds wrote:
> On Mon, Mar 31, 2014 at 7:49 AM, Ingo Molnar <[email protected]> wrote:
> > Neil Horman (1):
> > x86: Adjust irq remapping quirk for older revisions of 5500/5520
> > chipsets
>
> Before I pull this, I want somebody to double-check it:
>
> > - if (revision == 0x13)
> > + if (revision < 0x13)
> > set_irq_remapping_broken();
>
> This change does *not* match the comment just above it. The comment
> talks very much about revision 13.
>
> So the comment should be fixed, and/or that "< 0x13" should perhaps be
> "<= 0x13".
>
> Because making it "less than" simply makes no sense in light of the
> comment. Does revision 13 suddenly work? Was that where it was fixed?
> If so, please fix the comment.
That is my bad. I applied V1 of the patch instead of V2 which had the
<= 0x13 instead of < 0x13.
Please drop the pull request for now. I'll fix it up and we resubmit.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
