On Sat, Apr 12, 2014 at 12:09:34PM +0200, Pavel Machek wrote: > Hi! > > > > > > This permits to reassign keyboard LEDs to something else than > > > > > keyboard "leds" > > > > > state, by adding keyboard led and modifier triggers connected to a > > > > > series > > > > > of VT input LEDs, themselves connected to VT input triggers, which > > > > > per-input device LEDs use by default. Userland can thus easily > > > > > change the LED > > > > > behavior of (a priori) all input devices, or of particular input > > > > > devices. > > > > > > > > > > > > > I still have the same concern that I believe I already mentioned a while > > > > ago: how do we reconcile the LED control via triggers with LED control > > > > done through event devices? > > I think we should deprecate LED controls using event devices. We have > nice API for LEDs, and it is not in input. > > > > > > > > Currently, as far as I can see, they will be > > > > clashing with each other. I.e. if I remap my capslock led to be the new > > > > shiftlock and then userspace writes EV_LED/LED_CAPSL it would light up > > > > my new "shift lock", right? > > > > > > Well, yes, sure, if you shoot in your foot it will hurt :) (although > > > here the damage is really small, it is just LED lighting or not). > > > > This is not about amount of damage but the overall correctness of the > > implementation. I'd rather not have a solution with known holes, if > > possible. > > I'd say that applications using direct EV_LED interface should just > stop doing it. Yes, you can probably use led API and still toggle the > led using gpio api behind leds back (not tested, perhaps there are > interlocks that prevent that)... and it is same situation with > EV_LED. We should just teach applications not to do that. > > Would solution where EV_LED would be ignored when there's non-default > trigger selected work for you?
Not ignored but rather routed to the LED that is currently selected for given function. This way if I re-purposed CapsLock LED for Wifi and do not provide a replacement EV_LED will be effectively dropped, but if I switch CapsLock with NumLock I want the event to affect the appropriate LED. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
