On Sun, Apr 13, 2014 at 12:18 PM, Marek Vasut <ma...@denx.de> wrote: [...] >> +#define OPCODE_RDFSR 0x70 /* read flag status register */ > > I know this is not your fault, but can you please indent this properly with > tabs? > >> #define OPCODE_NORM_READ 0x03 /* Read data bytes (low > frequency) */ >> #define OPCODE_FAST_READ 0x0b /* Read data bytes (high > frequency) */ >> #define OPCODE_QUAD_READ 0x6b /* Read data bytes */ > > And fix this one in a separate patch to use tabs as well please ?
I'm rebasing on l2-mtd spinor, and the tabs are jacked up there too. I'll fix the one I added, and fix other tabs in a new patch on that branch. [...] > I wonder, can't wait_till_ready() be made a wrapper that will check the > USE_FSR > flag and call correct wait-function ? This would avoid adding a new member to > *flash and also would avoid so many changes throughout the code. What do you > think? Yeah, that's kind of ugly, but the flags exist only in the static m25p_ids[] and are only used in the scan/init. I'd have to add a new member to save them for later use. And then other uses would crop up. So, seemed kinda iffy either way. It's going to change anyway, because l2-mtd spinor branch has refactored wait_till_ready() such that it uses a function pointer from the new spi_nor struct. I'm still mulling it over :) Thanks, -Graham -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
