On śro, 2014-04-16 at 19:27 +0900, Sangjung Woo wrote: > Use the resource-managed extcon device register function (i.e. > devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device > is attached with this function, that extcon device is automatically > unregistered > on driver detach. That reduces tiresome managing code. > > Signed-off-by: Sangjung Woo <sangjung....@samsung.com> > --- > drivers/extcon/extcon-max8997.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Best regards, Krzysztof > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 223e6b0..804a446 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -709,7 +709,7 @@ static int max8997_muic_probe(struct platform_device > *pdev) > info->edev->name = DEV_NAME; > info->edev->dev.parent = &pdev->dev; > info->edev->supported_cable = max8997_extcon_cable; > - ret = extcon_dev_register(info->edev); > + ret = devm_extcon_dev_register(&pdev->dev, info->edev); > if (ret) { > dev_err(&pdev->dev, "failed to register extcon device\n"); > goto err_irq; > @@ -790,8 +790,6 @@ static int max8997_muic_remove(struct platform_device > *pdev) > free_irq(muic_irqs[i].virq, info); > cancel_work_sync(&info->irq_work); > > - extcon_dev_unregister(info->edev); > - > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/