To Seung-Woo.
On 04/16/2014 07:44 PM, Seung-Woo Kim wrote: > Hi, > > On 2014년 04월 16일 19:27, Sangjung Woo wrote: >> Use the resource-managed extcon device register function (i.e. >> devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon >> device >> is attached with this function, that extcon device is automatically >> unregistered >> on driver detach. That reduces tiresome managing code. >> >> Signed-off-by: Sangjung Woo <sangjung....@samsung.com> >> --- >> drivers/extcon/extcon-arizona.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/extcon/extcon-arizona.c >> b/drivers/extcon/extcon-arizona.c >> index 98a14f6..40e6c0b 100644 >> --- a/drivers/extcon/extcon-arizona.c >> +++ b/drivers/extcon/extcon-arizona.c >> @@ -1105,15 +1105,13 @@ static int arizona_extcon_probe(struct >> platform_device *pdev) >> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); >> if (!info) { >> dev_err(&pdev->dev, "Failed to allocate memory\n"); >> - ret = -ENOMEM; >> - goto err; >> + return -ENOMEM; >> } >> >> info->micvdd = devm_regulator_get(arizona->dev, "MICVDD"); >> if (IS_ERR(info->micvdd)) { >> - ret = PTR_ERR(info->micvdd); >> dev_err(arizona->dev, "Failed to get MICVDD: %d\n", ret); > Assignment to ret is removed but it is still used here. You're right. I will fix and send it as second version. Thank you for your comment. BRs, Sangjung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/