On 2014年04月23日 15:28, Mika Westerberg wrote: > On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: >> Hi Mika: >> Thanks a lot for your review. >> >> On 2014年04月22日 19:36, Mika Westerberg wrote: >>>>> + >>>>> + client.adapter = adapter; >>>>> + client.addr = sb->slave_address; >>>>> + client.flags = 0; >>> I'm not sure if this is the correct way to use struct i2c_client >>> (allocating it from stack and passing forward to functions that might >>> expect a real i2c_client structure). It has ->dev and all. >> >> I check all i2c_smbus_xxx helper functions and they are simple wrappers >> of i2c_smbus_xfer(). Only adapter, addr and flags of struct client are >> used in these functions. > > In that case I suppose it is OK to (ab)use the client structure like this. > > I think you still want to initialize the whole structure (unused fields > with zero) before passing it to the wrappers. >
Ok. I will do that. -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
